Add analyzer for power poles in france_centre_cher provided by SDE18 #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting #2392 to be solved |
flacombe
changed the title
flacombe
force-pushed
the
merge/sde18
branch
from
e11ab07 to
0d96fd4
Compare
|
Rar has been changed to zip, this analyzer can now be merged @frodrigo |
frodrigo
reviewed
Dec 7, 2024
| dataset="673b1255be2baa1d2a71c950", | ||
| resource="3d617c33-05e1-4190-a3ca-802d94dad509" | ||
| ), | ||
| srid = 2154, zip="*.shp"), |
There was a problem hiding this comment.
If shp contains the projection, better let it come from the shp rather than force it.
Suggested change
| srid = 2154, zip="*.shp"), | |
| srid = 2154, zip="*.shp"), |
There was a problem hiding this comment.
I'm a bit puzzled: what if data provider remove the .prj without notice?
There was a problem hiding this comment.
I looks more probable to me that they change the srid, rather than remove .proj
There was a problem hiding this comment.
Ok, srid has been removed from all power pole merge analyzers
|
Thank, merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDE 18 is a local authority in Cher (France) who manager public distribution grid and street lights.
They recently published street light points that could be useful to complete power poles there.
This new analysis has been setup from scratch without reusing abstract graceTHD since the data structure doesn't match the national standard and is provided under a custom fashion.